Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Formula 1 race replay file watcher sources so the app can detect newly created .frr replay files in the user’s Documents replay folders, including a “latest installed” auto-detection option.
Changes:
- Introduces a shared
F1RaceReplaySourceBasewith common path and default-option helpers for F1 replay monitoring. - Adds a general
F1RaceReplaySourcewith optional custom path and “auto-detect latest installed” logic. - Adds year-specific sources for F1 2022–2025 with fixed default replay paths.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| GamesDat/Telemetry/Sources/Formula1/F1RaceReplaySourceBase.cs | Shared base for F1 replay sources (path building + default option helpers). |
| GamesDat/Telemetry/Sources/Formula1/F1RaceReplaySource.cs | Primary F1 replay source with defaulting + optional latest-installed detection. |
| GamesDat/Telemetry/Sources/Formula1/F12025RaceReplaySource.cs | Year-specific source defaulting to the F1 25 replay folder. |
| GamesDat/Telemetry/Sources/Formula1/F12024RaceReplaySource.cs | Year-specific source defaulting to the F1 24 replay folder. |
| GamesDat/Telemetry/Sources/Formula1/F12023RaceReplaySource.cs | Year-specific source defaulting to the F1 23 replay folder. |
| GamesDat/Telemetry/Sources/Formula1/F12022RaceReplaySource.cs | Year-specific source defaulting to the F1 22 replay folder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
|
@codegefluester I've opened a new pull request, #13, to work on those changes. Once the pull request is ready, I'll request review from you. |
… sources (#13) * Initial plan * Fix EnsurePath to return new instances and update foreach to Select Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Extract debounce delay constants for better maintainability Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Add clarifying comments and improve variable naming Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> * Document library default coupling in constant Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: codegefluester <203914+codegefluester@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F1 allows users to save race replays, while the format is proprietary, it still makes sense to allow someone to detect them and then process/upload them further